Add native types #812
Merged
Add native types #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
add_native_types
branch
from
97f2648 to
7518031
Compare
malarzm
approved these changes
Dec 14, 2023
|
Thanks @franmomu! |
GromNaN
reviewed
Dec 14, 2023
| * | ||
| * @return string | ||
| */ | ||
| /** @internal Symfony 2.8 compatibility */ |
There was a problem hiding this comment.
This looks like something that can be removed.
GromNaN
reviewed
Dec 14, 2023
| * | ||
| * @return string | ||
| */ | ||
| /** @internal Symfony 2.8 compatibility */ | ||
| #[ReturnTypeWillChange] |
There was a problem hiding this comment.
Since the return type have been modified, this attribute is no longer necessary.
GromNaN
reviewed
Dec 14, 2023
| * @param string $class | ||
| * | ||
| * @return FixtureInterface | ||
| * @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingAnyTypeHint |
There was a problem hiding this comment.
I hope this will be fixed with doctrine/data-fixtures#455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds native types using PHPCS